[Webkit-unassigned] [Bug 90758] Refactoring metadata of BitmapImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90758





--- Comment #6 from Huang Dongsung <luxtella at company100.net>  2012-07-11 00:34:31 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Created an attachment (id=151426)
 --> (https://bugs.webkit.org/attachment.cgi?id=151426&action=review) [details] [details] [details]
> > > Patch
> > 
> > Add "m_frames[0].m_isComplete = true" in BitmapImage(NativeImagePtr, ImageObserver* = 0).
> > BitmapImage(NativeImagePtr, ImageObserver* = 0) is implemented by each platform, and most of them does not clarify "m_frames[0].m_isComplete = true" except for VG port.
> > BitmapImage(NativeImagePtr, ImageObserver* = 0) means to create new image with a complete platform image, so "m_frames[0].m_isComplete = true" is proper.
> 
> I am not sure if this change should belong to this patch because m_isComplete is not a metadata by our definition. We also need to explain more about the consequences of this change. e.g., How does this change impact parallel image decoders?

Ok. I explain more detail about m_isComplete in ChangeLog.

3. Set m_isComplete to true in BitmapImage(NativeImagePtr, ImageObserver*).
This constructor creates a BitmapImage from a platform specific NativeImagePtr.
It sets m_frame of the first frame to the given NativeImagePtr.
The BitmapImage created does not need decoding because decoding is already done.
So, it is proper to set m_isComplete to true. Currently, only OpenVG
port sets m_isComplete to true.

The third change is needed for parallel image decoders. Currently,
BitmapImage checks only m_frame in order to determine whether decoding
is needed or not. But after parallel image decoders are landed,
BitmapImage also needs to check m_isComplete. If m_isComplete is false,
BitmapImage will try to decode again, and it can't actually decode
because the BitmapImage created from a NativeImagePtr does not have
encoded data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.