[Webkit-unassigned] [Bug 90936] [EFL] Add a API for getting security origin string

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 10 22:58:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90936





--- Comment #3 from Kihong Kwon <kihong.kwon at samsung.com>  2012-07-10 22:58:06 PST ---
(From update of attachment 151594)
View in context: https://bugs.webkit.org/attachment.cgi?id=151594&action=review

>> Source/WebKit/efl/ewk/ewk_security_origin.cpp:59
>> +const char* ewk_security_origin_string_get(Ewk_Security_Origin *origin)
> 
> star should be next to Ewk_Security_Origin, not origin.

OK.

>> Source/WebKit/efl/ewk/ewk_security_origin.h:78
>> + * Returns the security origin string from Ewk_Security_Origin.
> 
> Returns the string representation of the security origin?

OK. Thanks.

>> Source/WebKit/efl/ewk/ewk_security_origin.h:84
>> +EAPI const char          *ewk_security_origin_string_get(Ewk_Security_Origin *o);
> 
> Argument should be const.

It can't be.
Argument can be changed in the ewk_security_origin_string_get.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list