[Webkit-unassigned] [Bug 90936] [EFL] Add a API for getting security origin string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90936





--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-10 22:35:53 PST ---
(From update of attachment 151594)
View in context: https://bugs.webkit.org/attachment.cgi?id=151594&action=review

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:59
> +const char* ewk_security_origin_string_get(Ewk_Security_Origin *origin)

star should be next to Ewk_Security_Origin, not origin.

> Source/WebKit/efl/ewk/ewk_security_origin.h:78
> + * Returns the security origin string from Ewk_Security_Origin.

Returns the string representation of the security origin?

> Source/WebKit/efl/ewk/ewk_security_origin.h:79
> + *

It would be nice to copy the doc from WebCore here to provide more information: e.g. "Convert this SecurityOrigin into a string. The string representation of a SecurityOrigin is similar to a URL, except it lacks a path component. The string representation does not encode the value of the security origin's domain property".

We should document that it may return the string "null" when the security origin is unique (check WebCore::SecurityOrigin::toString() documentation for more details).

> Source/WebKit/efl/ewk/ewk_security_origin.h:82
> + * @return url stirng from Ewk_Securiry_Origin.

It does not necessarily return a URL and there is a type in "string". I would use "String representation of the security origin".

> Source/WebKit/efl/ewk/ewk_security_origin.h:84
> +EAPI const char          *ewk_security_origin_string_get(Ewk_Security_Origin *o);

Argument should be const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.