[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 10 21:50:49 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=87935
--- Comment #13 from Seokju Kwon <seokju.kwon at samsung.com> 2012-07-10 21:50:48 PST ---
(In reply to comment #12)
> (From update of attachment 151428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151428&action=review
>
> > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:529
> > +#if ENABLE(INSPECTOR)
>
> This should be at the beginning of the function, not in the middle.
>
> > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:153
> > + evas_object_focus_set(inspectorView, EINA_TRUE);
>
> I believe you should use "true" here instead of EINA_TRUE, as per guidelines.
>
> > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:167
> > + if (inspectorView) {
>
> You already return earlier if inspectorView is NULL so it seems this check is not needed, right?
>
I will fix all that you mentioned.
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:770
> > + // Waits until web inspector resources are loaded
>
> I don't understand why this is needed, could you explain?
Like what I said on comment #10, Drt have to wait until 'inspector.html' called web inspector is loaded totally. Because some objects in web inspector are called in test files (like LayoutTests/http/tests/inspector/inspector-test.js, LayoutTests/http/tests/inspector/console-test.js ...)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list