[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87935





--- Comment #12 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-10 12:58:26 PST ---
(From update of attachment 151428)
View in context: https://bugs.webkit.org/attachment.cgi?id=151428&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:529
> +#if ENABLE(INSPECTOR)

This should be at the beginning of the function, not in the middle.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:153
> +    evas_object_focus_set(inspectorView, EINA_TRUE);

I believe you should use "true" here instead of EINA_TRUE, as per guidelines.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:167
> +    if (inspectorView) {

You already return earlier if inspectorView is NULL so it seems this check is not needed, right?

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:770
> +    // Waits until web inspector resources are loaded

I don't understand why this is needed, could you explain?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.