[Webkit-unassigned] [Bug 90116] [Qt] Repaint counter for accelerated compositing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90116


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151483|review?                     |review-
               Flag|                            |




--- Comment #5 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-07-10 10:46:36 PST ---
(From update of attachment 151483)
View in context: https://bugs.webkit.org/attachment.cgi?id=151483&action=review

Let's put the #if PLATFORM(QT) only when actually needed, this will help other ports (EFL?) do this when they so choose.

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:127
> +#if PLATFORM(QT)
> +    virtual void drawRepaintCounter(int value, int pointSize, const FloatPoint&, const TransformationMatrix& modelViewMatrix = TransformationMatrix()) = 0;
> +#endif

Doesn't need ifdef

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:364
> +#if PLATFORM(QT)
> +void TextureMapperGL::drawRepaintCounter(int value, int pointSize, const FloatPoint& targetPoint, const TransformationMatrix& modelViewMatrix)

#if should be inside, notImplemented otherwise.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:55
> +#if PLATFORM(QT)
> +    virtual void drawRepaintCounter(int value, int pointSize, const FloatPoint&, const TransformationMatrix& modelViewMatrix = TransformationMatrix()) OVERRIDE;
> +#endif

Doesn't need ifdef

> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:57
> +#if PLATFORM(QT)
> +    virtual void drawRepaintCounter(int value, int pointSize, const FloatPoint&, const TransformationMatrix& modelViewMatrix = TransformationMatrix()) OVERRIDE { };
> +#endif

ditto

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:103
> +#if PLATFORM(QT)
> +static bool shouldShowTileDebugVisuals()
> +{
> +    return (qgetenv("QT_WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS") == "1");
> +}

You can put the ifdef inside, and return false if not in Qt.

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:146
> +#if PLATFORM(QT)
> +        static bool shouldDebug = shouldShowTileDebugVisuals();
> +        if (!shouldDebug)
> +            continue;
> +        textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform);
> +        textureMapper->drawRepaintCounter(static_cast<LayerBackingStoreTile*>(tile)->repaintCount(), 8, tilesToPaint[i]->rect().location(), transform);
> +#endif

Doesn't need the ifdef

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.h:40
> +#if PLATFORM(QT)
> +        , m_repaintCount(0)
> +#endif

Doesn't need the ifdef

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.h:48
> +#if PLATFORM(QT)
> +    inline void incrementRepaintCount() { ++m_repaintCount; }
> +    inline int repaintCount() const { return m_repaintCount; }
> +#endif

Doesn't need the ifdef

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.h:60
> +#if PLATFORM(QT)
> +    int m_repaintCount;
> +#endif

Doesn't need the ifdef

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.