[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #57 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-07-10 07:30:55 PST ---
(From update of attachment 151085)
View in context: https://bugs.webkit.org/attachment.cgi?id=151085&action=review

Thank you for your review!

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:100
>> +    void setWhitespaceWidth(float w) { m_whitespaceWidth = w; }
> 
> Please don't abbreviate width as w.

O.K.

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2567
>> +            float inlineLogicalW = inlineLogicalWidth(current.m_obj, !appliedStartWidth, includeEndWidth);
> 
> Ditto.

Done.

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2571
>> +                width.setWhitespaceWidth(additionalTmpW + inlineLogicalW);
> 
> Why don't you care about previousCharacterIsSpace here? 
> 
> I also think what's happening here is sufficiently non-obvious to deserve a comment.
> 
> Nit: I think the 'W' thing is a bad idea - maybe just call it inlineLogicalWidth.

previsousCharacterIsSpace is out of scope here, and it seems no problem though we don't take care of it here.
Done. inlineLogicalW -> inlineLogicalTempWidth

>> LayoutTests/ChangeLog:26
>> +        * fast/inline-block/multiple-floats-with-whitespace.html: Added.
> 
> Would you mind adding floats-001.htm and floats-102.htm from the CSS test suite - this patch fixes them. See http://test.csswg.org/suites/css2.1/nightly-unstable/html4/

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.