[Webkit-unassigned] [Bug 90839] Secure input can be enabled permanently due to logic error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90839


Alexey Proskuryakov (on vacation until 7/18) <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org




--- Comment #1 from Alexey Proskuryakov (on vacation until 7/18) <ap at webkit.org>  2012-07-10 06:52:21 PST ---
> We have a number of reports that this problem is common with Chrome. It's not common with Safari, but perhaps Safari has a higher-level workaround.

This is confusing. The code is only used in Safari, not in Chrome or any other Mac applications. This code is in WebKit2 framework, while Chrome has a completely custom implementation, and regular Mac applications use the original WebKit framework.

> However later in the method when EnableSecureEventInput() is called, the internal flag is untouched

This observation is not true. The flag is reset in the last line of the function:

    _data->_inSecureInputState = isInPasswordField;

I don't see a bug in this webkit.org code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.