[Webkit-unassigned] [Bug 90116] [Qt] Repaint counter for accelerated compositing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90116


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151401|review?                     |review-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-07-10 06:26:03 PST ---
(From update of attachment 151401)
View in context: https://bugs.webkit.org/attachment.cgi?id=151401&action=review

> Source/WebCore/ChangeLog:17
> +        Note that there is no integration with Preferences. That aproach was
> +        taken initially but revealed complex and overkill for such a
> +        debugging-only functionality. Thus, to disable it simply restart with
> +        the environment variable unset or set to some other value.

Please explain what you've changed in TextureMapper[GL]

> Source/WebKit2/ChangeLog:9
> +

You should note somewhere that this is for WebKit2 only for now.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:368
> +    QFont font(QStringLiteral("Monospace"), pointSize, QFont::Bold);

QString::fromUtf8 would work, seems like QStringLiteral doesn't build.

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:136
> +        static bool showTileDebugVisuals = (qgetenv("QT_WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS") == "1");
> +        if (!showTileDebugVisuals)
> +            continue;

This should be in its own (static) function

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.