[Webkit-unassigned] [Bug 90758] Refactoring metadata of BitmapImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90758





--- Comment #4 from Kwang Yul Seo <skyul at company100.net>  2012-07-10 06:17:29 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=151426)
 --> (https://bugs.webkit.org/attachment.cgi?id=151426&action=review) [details] [details]
> > Patch
> 
> Add "m_frames[0].m_isComplete = true" in BitmapImage(NativeImagePtr, ImageObserver* = 0).
> BitmapImage(NativeImagePtr, ImageObserver* = 0) is implemented by each platform, and most of them does not clarify "m_frames[0].m_isComplete = true" except for VG port.
> BitmapImage(NativeImagePtr, ImageObserver* = 0) means to create new image with a complete platform image, so "m_frames[0].m_isComplete = true" is proper.

I am not sure if this change should belong to this patch because m_isComplete is not a metadata by our definition. We also need to explain more about the consequences of this change. e.g., How does this change impact parallel image decoders?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.