[Webkit-unassigned] [Bug 90688] [EFL][Wk2] WebErrorsEfl.cpp needs to return non-empty errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90688





--- Comment #21 from Keunsoon Lee <keunsoon.lee at samsung.com>  2012-07-10 04:18:41 PST ---
(In reply to comment #19)
> (From update of attachment 151399 [details])
> Can you add tests for this change?
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=151399&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:45
> > +    return ResourceError("NetworkErrorDomain", -999,
> 
> what about defining the string NetworkErrorDomain as a constant, as it's used several times?
> 
> And define -999 and -998 as constants as well, so at least in this file, they have meaningful names?
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:46
> > +            request.url().string(), "Request cancelled");
> 
> nit. should fit in one line (here and all other return statements in this change)

Thanks for the review.
I attached new patch for your review; attachment (id=151434) .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.