[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87935





--- Comment #10 from Seokju Kwon <seokju.kwon at samsung.com>  2012-07-10 03:26:48 PST ---
(In reply to comment #9)
> (From update of attachment 151398 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151398&action=review
> 
> > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:69
> > +    if (newMessage.contains("Localized string") || (newMessage.contains("Protocol Error: the message is for non-existing domain 'Profiler'")))
> 
> nit : Why do you use unneeded ( ) in second condition ?
> 
> if (newMessage.contains("Localized string") || newMessage.contains("Protocol Error: the message is for non-existing domain 'Profiler'")) ?

I will remove it.

> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:770
> > +    // Waits until web inspector resources are loaded
> 
> In code level, I don't understand what do you need to wait ?
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:773
> > +        ecore_main_loop_begin();
> 
> I wonder if this is meaningful? Because ecore_main_loop_begin() is already called at the beginning of layout test.
> 
> http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L257

Test files are using 'WebInspector' object. It is implemented in resources of web inspector(frontend). So Dumprendertree should wait until resources are loaded totally('load, finished'). If not, drt fails tests with error message below.
"ReferenceError: Can't find variable: WebInspector"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.