[Webkit-unassigned] [Bug 90688] [EFL][Wk2] WebErrorsEfl.cpp needs to return non-empty errors
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 10 03:02:41 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=90688
--- Comment #19 from jochen at chromium.org 2012-07-10 03:02:40 PST ---
(From update of attachment 151399)
Can you add tests for this change?
View in context: https://bugs.webkit.org/attachment.cgi?id=151399&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:45
> + return ResourceError("NetworkErrorDomain", -999,
what about defining the string NetworkErrorDomain as a constant, as it's used several times?
And define -999 and -998 as constants as well, so at least in this file, they have meaningful names?
> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:46
> + request.url().string(), "Request cancelled");
nit. should fit in one line (here and all other return statements in this change)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list