[Webkit-unassigned] [Bug 90850] [Qt] REGRESSION(r122175): It broke the Windows build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90850


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org




--- Comment #1 from Csaba Osztrogonac <ossy at webkit.org>  2012-07-10 02:12:09 PST ---
I made some digging: Building ossource_posix.cpp was disabled 
on win previously, not only this file, but WEBGL was disabled:

features.prf:
...
# WebGL support
!contains(DEFINES, ENABLE_WEBGL=.) {
    contains(QT_CONFIG, opengl):!win32-*: DEFINES += ENABLE_WEBGL=1
}
...

Before r122175 building of these files was in ENABLE_WEBGL _and_  contains(QT_CONFIG, opengl) | contains(QT_CONFIG, opengles2) blocks.
After r122175 building of these files are in USE(3DGRAPHICS) block.

I think the problem is that we try to build ossource_posix.cpp for Windows.
If we really want to enable 3DGRAPHICS on Windows, we should use ossource_win.cpp instead of ossource_posix.cpp. Or we should disable 3DGRAPHICS on Windows.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.