[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 10 02:02:48 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87935





--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-10 02:02:48 PST ---
(From update of attachment 151398)
View in context: https://bugs.webkit.org/attachment.cgi?id=151398&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:69
> +    if (newMessage.contains("Localized string") || (newMessage.contains("Protocol Error: the message is for non-existing domain 'Profiler'")))

nit : Why do you use unneeded ( ) in second condition ?

if (newMessage.contains("Localized string") || newMessage.contains("Protocol Error: the message is for non-existing domain 'Profiler'")) ?

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:770
> +    // Waits until web inspector resources are loaded

In code level, I don't understand what do you need to wait ?

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:773
> +        ecore_main_loop_begin();

I wonder if this is meaningful? Because ecore_main_loop_begin() is already called at the beginning of layout test.

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L257

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list