[Webkit-unassigned] [Bug 90721] Don't destory the decoded data of an image if WebKit is about to render the image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90721





--- Comment #8 from Huang Dongsung <luxtella at company100.net>  2012-07-09 16:57:16 PST ---
(In reply to comment #6)
> (From update of attachment 151179 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151179&action=review
> 
> Looks close, with some name tweaking.
> 
> > Source/WebCore/loader/cache/CachedResource.h:215
> > +    virtual bool likelyToUseSoon() { return false; }
> 
> This should be const. I think "likelyToBeUsedSoon() const" would be better.

Done. I removed the argument CachedImage* of CacheImage::willRenderImage because I want to use willRenderImage in likelyToBeUsedSoon() "const" and the argument is not used anyway.

> 
> > Source/WebCore/loader/cache/MemoryCache.cpp:233
> > +            // Check to see if the remaining resources are too high chance that the CachedResource uses soon to prune.
> 
> This comment doesn't make sense.

I'm sorry. I clarified the comment.

> 
> > Source/WebCore/loader/cache/MemoryCache.cpp:235
> > +            if (current->likelyToUseSoon())
> > +                return;
> 
> Why does this return, and not continue?

Done. See the comment above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.