[Webkit-unassigned] [Bug 89000] [CSS Regions] Fix the lifecycle for the flow objects and their renderers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89000





--- Comment #30 from Eric Seidel <eric at webkit.org>  2012-07-09 16:04:33 PST ---
(From update of attachment 150589)
View in context: https://bugs.webkit.org/attachment.cgi?id=150589&action=review

> Source/WebCore/dom/WebKitNamedFlowCollection.cpp:95
> +    m_namedFlows.add(newFlow.get());
> +    ++m_createdFlowsCount;

It's not clear to me why it's better to have a single unified list, and a side-cound, instead of two lists?  can flowByName() find non-created flows?  What advantages do we get by having them all in one set?

> Source/WebCore/dom/WebKitNamedFlowCollection.cpp:129
> +    static const bool safeToCompareToEmptyOrDeleted = true;

Why is this true?  Won't the equal function crash if passed an empty or deleted object?  I'm not really sure what this does.

> Source/WebCore/rendering/RenderNamedFlowThread.h:69
> +    NamedFlowContentNodes& contentNodes() { return m_contentNodes; }

I think normally we return things by pointer, but I'm also not sure it matters.  Why is this non-const now?

> Source/WebCore/rendering/RenderNamedFlowThread.h:83
> +    inline bool canBeDestroyed() const { return m_regionList.isEmpty() && m_contentNodes.isEmpty(); }

inline does nothing here.  all methods declared in the header are implicity "inline" as far as I know.  "inline" is just a hint to the compiler. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.