[Webkit-unassigned] [Bug 90765] garden-o-matic should refuse rebaseline for reftests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 9 16:02:39 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90765





--- Comment #3 from Hayato Ito <hayato at chromium.org>  2012-07-09 16:02:38 PST ---
(In reply to comment #2)
> It should already do hide the rebaseline button for reftests. Did you see a case where it doesn't?

Yes. Yesterday, when I was gardening, I saw 'Rebaseline' button for a single test, 'fast/text-autosizing/simple-paragraph.html' on the main page.  It was not grouped. As far as I remembered, I clicked a 'Rebaseline' button for the test, and I noticed it was a reftest after a patch was created by garden-o-matic.

> 
> Oh, on the main page where tests are grouped together, I suppose it still shows the rebaseline button. I was thinking that we actually need to make webkit-patch be a noop for rebaselining reftests. Fixing it at that level is better because it means that other users of the webkit-patch command will also be safe.

That sounds nice. webkit-patch is a good place as a last defense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list