[Webkit-unassigned] [Bug 90640] Reproducible crasher when pasting a 0x0 image into Mail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90640


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151268|review?                     |review-
               Flag|                            |




--- Comment #9 from Brady Eidson <beidson at apple.com>  2012-07-09 15:12:38 PST ---
(From update of attachment 151268)
View in context: https://bugs.webkit.org/attachment.cgi?id=151268&action=review

Close - Let's give it one more shot.

> Source/WebCore/ChangeLog:9
> +        Editing: Reproducible crasher when pasting a 0x0 image into Mail
> +        https://bugs.webkit.org/show_bug.cgi?id=90640
> +        <rdar://problem/11141920>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        patch the crash by checking for nil.

Can be a bit more descriptive here.

Something like:
"0x0 images don't get a resource representation in the WebArchive so we need a null check"

> Tools/ChangeLog:26
> +2012-07-09  Alice Cheng  <alice_cheng at apple.com>
> +
> +        Editing: Reproducible crasher when pasting a 0x0 image into Mail
> +        https://bugs.webkit.org/show_bug.cgi?id=90640
> +        <rdar://problem/11141920>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test cases for the patch that checks for nil.
> +
> +        * TestWebKitAPI/Tests/mac/0.png: Added.
> +        * TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.
> +        (TestWebKitAPI):
> +        (TestWebKitAPI::TEST):
> +
> +2012-07-09  Alice Cheng  <alice_cheng at apple.com>
> +
> +        Need a short description and bug URL (OOPS!)
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * TestWebKitAPI/Tests/mac/0.png: Added.
> +        * TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.
> +        (TestWebKitAPI):
> +        (TestWebKitAPI::TEST):
> +

Some leftover ChangeLog cruft here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.