[Webkit-unassigned] [Bug 90817] [BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 9 14:31:25 PDT 2012


--- Comment #4 from Crystal Zhang <haizhang at rim.com>  2012-07-09 14:31:25 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 151316 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=151316&action=review
> > 
> > > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147
> > > +    ASSERT(m_element);
> > 
> > Which one is it?  Can it, or can it not be null?
> It is assigned through ctor, but cleared when the popup is closed. However the JS object is still there. It is theoretically possible the method is called by JS, e.g., window.popPup.setValueAndClosePopup().
> Crystal, is that possible?
window.popPup.setValueAndClosePopup() will only be called by popup's JS file, if you want to be safe, we can add guard here, however ASSERT should be removed then, as they are conflicting each other.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list