[Webkit-unassigned] [Bug 90688] [EFL][Wk2] WebErrorsEfl.cpp needs to return non-empty errors
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 9 04:11:40 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=90688
--- Comment #7 from Keunsoon Lee <keunsoon.lee at samsung.com> 2012-07-09 04:11:38 PST ---
(In reply to comment #5)
> (From update of attachment 151210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151210&action=review
>
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:41
> > + /* FIXME remove magic number -999 and string "NetworkErrorDomain".
>
> Use // instead of /* ... */. Then, use *FIXME:*
>
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:42
> > + * application cannot understand those.
>
> s/application/Application/g
>
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:43
> > + * should establish EFL port's error system */
>
> Please write completed sentence.
>
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:74
> > + /* FIXME remove magic number -998 and string "NetworkErrorDomain".
>
> ditto.
Hi,
I attached modified patch below.
Thank you for your review.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list