[Webkit-unassigned] [Bug 90505] Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 8 22:56:04 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90505





--- Comment #8 from Huang Dongsung <luxtella at company100.net>  2012-07-08 22:56:04 PST ---
(In reply to comment #6)
> > Is it better that I comment it on Changelog or CPP file?
> 
> ChangeLog.
I added the explanation in ChangeLog.
> 
> As you're fixing a bug, the obvious question is - can it be tested?
Unfortunately, I could not verify my statement by test.
I mentioned CG port possibly had a bug after reading code, not testing.
I tried to make test it but it is hard to get the animated GIF that has the frame with alpha channel and another frame without alpha channel.
And, most animated GIF is with alpha channel or without channel, not hybrid, so previous implementation rarely show the defect in real sites or tests.

IMHO, changing frameHasAlphaAtIndex(0) to currentFrameHasAlpha() is proper and easy to understand, but if it is not enough due to the lack of test, I'll try to make the test again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list