[Webkit-unassigned] [Bug 90596] Move element/tag category query functions to a separate file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 8 19:01:49 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90596





--- Comment #18 from Kwang Yul Seo <skyul at company100.net>  2012-07-08 19:01:48 PST ---
(In reply to comment #17)
> I really appreciate you looking through all these parser FIXMEs.  As Adam points out, we wrote a whole bunch of FIXMEs while writing the parser.  Not all of which we really should fix.  It's nice that someone is looking through them!

Thanks. One particular FIXME I really want to remove is in HTMLPreloadScanner::scan()

    // FIXME: We should save and re-use these tokens in HTMLDocumentParser if
    // the pending script doesn't end up calling document.write.
    while (m_tokenizer->nextToken(m_source, m_token)) {
        processToken();
        m_token.clear();
    }   

HTMLPreloadScanner is nice, but it fails to save and reuse the tokens because it just uses an approximation of how the tree builder would update the tokenizer's state.

I want to teach HTMLDocumentParser to parse speculatively (in addition to preloading) while it is waiting for scripts. I will file a bug and share my initial design.

Looking through all these parser FIXMEs is a good way to learn the parser code base. I really appreciate your review. Thanks Adam and Eric.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list