[Webkit-unassigned] [Bug 90284] [GTK] WebKit test runner ignores all system environment variables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90284





--- Comment #11 from Dirk Pranke <dpranke at chromium.org>  2012-07-08 11:58:05 PST ---
(In reply to comment #10)
> Created an attachment (id=151087)
 --> (https://bugs.webkit.org/attachment.cgi?id=151087&action=review) [details]
> Patch
> 
> Now only variables prefixed with WEBKIT_TESTS_ are passed to the tests (by removing the prefix first). I hope this makes the process enough sandboxed but with some flexibility. If you like the proposed solution I can write some tests and submit a final patch for review.

As I said above, I'm not wild about WEBKIT_TESTS_, either. Do you really need to be able to update arbitrary environment variables? Is there a reason you don't just add the variables you care about to the whitelist, either in base.py or override setup_environ_for_server in gtk.py if only gtk cares about GST_PLUGIN_SYSTEM_PATH (which seems likely)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.