[Webkit-unassigned] [Bug 90692] WebCore doesn't build with recent clang (w/ patch)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 23:48:19 PDT 2012


--- Comment #10 from Alexey Proskuryakov (on vacation until 7/18) <ap at webkit.org>  2012-07-06 23:48:18 PST ---
(From update of attachment 151103)
View in context: https://bugs.webkit.org/attachment.cgi?id=151103&action=review

> Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:80
> +    (void)m_alphaOption;
> +    (void)m_gammaAndColorProfileOption;

Why did you choose to keep these? The (void) trick is not something we normally do in WebKit code.

If this is really necessary, please add a comment.

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:61
> +        /* : m_graphicsContext3D(graphicsContext3D) */

As a strong rule, we don't check in commented out code. Not sure who can comment about the refactoring plans for this class.

 94083 cmarrin at apple.com // FIXME: This class is currently empty on Mac, but will get populated as 
 94083 cmarrin at apple.com // the restructuring in https://bugs.webkit.org/show_bug.cgi?id=66903 is done

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list