[Webkit-unassigned] [Bug 90505] Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90505





--- Comment #4 from Huang Dongsung <luxtella at company100.net>  2012-07-06 20:57:06 PST ---
(In reply to comment #3)
> Could you please elaborate why this needs to be done? Clearly, this is not a build fix.
> 
> -    bool hasAlpha = image->isBitmapImage() ? static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0) : true;
> +   bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true;
> 
> This looks suspicious - are frame 0 and current one the same?

PNG, JPEG, BMP, and WEBP's current is always 0.

GIF and ICO can have an other integer as current index.

It means that previous implementation has bug about alpha because the impl expects the alpha of image->nativeImageForCurrentFrame() is image->frameHasAlphaAtIndex(0).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.