[Webkit-unassigned] [Bug 40300] Web Inspector: [JSC] implement script source editing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40300





--- Comment #52 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-07-06 16:24:54 PST ---
(In reply to comment #49)
> (From update of attachment 151015 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151015&action=review
> 
> > Source/WebCore/bindings/js/ScriptDebugServer.cpp:207
> >  bool ScriptDebugServer::setScriptSource(const String&, const String&, bool, String*, ScriptValue*, ScriptObject*)
> >  {
> > -    // FIXME(40300): implement this.
> > +    ASSERT_NOT_REACHED();
> >      return false;
> >  }
> 
> As pointed by Konrad, ASSERT_NOT_REACHED() looks weird here because pure virtual function makes more sense. sorry for my old suggestion.

I agree with Konrad that pure virtual function is better, but some porting derived their own new class form "ScriptDebugServer", pure virtual function will break their own code :(.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.