[Webkit-unassigned] [Bug 90694] Add an API to explicitly call a JavaScript function with args.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90694


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dglazkov at chromium.org




--- Comment #2 from Yong Li <yoli at rim.com>  2012-07-06 10:21:38 PST ---
(From update of attachment 151098)
View in context: https://bugs.webkit.org/attachment.cgi?id=151098&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:951
> +        size_t bufferSize = JSStringGetMaximumUTF8CStringSize(stringRef);
> +        char* buffer = new char[bufferSize];
> +        size_t s2 = JSStringGetUTF8CString(stringRef, buffer, bufferSize);
> +        returnValue = WebString(buffer, s2);
> +        delete buffer;

should be delete[]. actually we should use Vector<char>. Also, WebString is supposed to be either UTF16 or latin1. probably we should use WebString::fromUtf8()? or consider using std::string?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.