[Webkit-unassigned] [Bug 90608] [CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 05:20:54 PDT 2012


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #150940|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #2 from Andreas Kling <kling at webkit.org>  2012-07-06 05:20:54 PST ---
(From update of attachment 150940)
View in context: https://bugs.webkit.org/attachment.cgi?id=150940&action=review

r=me with tiny tweaks:

> LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html:18
> +    description("Test for 90608: [CSSRegions]Implement NamedFlow::firsEmptyRegionIndex attribute.");

Typo, firsEmptyRegionIndex.

> Source/WebCore/dom/WebKitNamedFlow.cpp:66
> +    int index;

This variable should be scoped to the for loop below.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list