[Webkit-unassigned] [Bug 90631] Web Inspector: display function scope in UI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 23:34:07 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90631


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151000|review?                     |review-
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2012-07-05 23:34:06 PST ---
(From update of attachment 151000)
View in context: https://bugs.webkit.org/attachment.cgi?id=151000&action=review

> Source/WebCore/ChangeLog:8
> +        TBD

Please fill in the change description.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:251
> +            if (this.property.value.type == "function") {

We use === in the front-end code, also no braces for one-line blocks.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:500
> +                var subtitle = " ";

I'd rather assign it to null here.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:502
> +                switch (scope.type) {

style nit: "A case label should line up with its switch statement"

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:544
> +        this.hasChildren = true;

Why not initialize this in the constructor?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list