[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003


Michael Saboff <msaboff at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msaboff at apple.com




--- Comment #50 from Michael Saboff <msaboff at apple.com>  2012-07-05 18:13:33 PST ---
I tried compiling the proposed patch on ToT (r121930)  and died with the compilation error below.  Looks like some other code needs to have a column parameter added.  I was building to check performance implications of the patch.

In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:57:18: error: 'WebScriptDebugger::callEvent' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void callEvent(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineNumber);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:47:22: note: hidden overloaded virtual function 'JSC::Debugger::callEvent' declared here
        virtual void callEvent(const DebuggerCallFrame&, intptr_t, int, int) { };
                     ^
In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:58:18: error: 'WebScriptDebugger::atStatement' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void atStatement(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineNumber);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:46:22: note: hidden overloaded virtual function 'JSC::Debugger::atStatement' declared here
        virtual void atStatement(const DebuggerCallFrame&, intptr_t, int, int) { };
                     ^
In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:59:18: error: 'WebScriptDebugger::returnEvent' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void returnEvent(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineNumber);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:48:22: note: hidden overloaded virtual function 'JSC::Debugger::returnEvent' declared here
        virtual void returnEvent(const DebuggerCallFrame&, intptr_t, int, int) { };
                     ^
In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:60:18: error: 'WebScriptDebugger::exception' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void exception(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineNumber, bool hasHandler);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:45:22: note: hidden overloaded virtual function 'JSC::Debugger::exception' declared here
        virtual void exception(const DebuggerCallFrame&, intptr_t, int, int, bool) { };
                     ^
In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:61:18: error: 'WebScriptDebugger::willExecuteProgram' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void willExecuteProgram(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineno);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:50:22: note: hidden overloaded virtual function 'JSC::Debugger::willExecuteProgram' declared here
        virtual void willExecuteProgram(const DebuggerCallFrame&, intptr_t, int, int) { };
                     ^
In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:62:18: error: 'WebScriptDebugger::didExecuteProgram' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void didExecuteProgram(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineno);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:51:22: note: hidden overloaded virtual function 'JSC::Debugger::didExecuteProgram' declared here
        virtual void didExecuteProgram(const DebuggerCallFrame&, intptr_t, int, int) { };
                     ^
In file included from /Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebFrame.mm:51:
/Volumes/Data/src/webkit.work/Source/WebKit/mac/WebView/WebScriptDebugger.h:63:18: error: 'WebScriptDebugger::didReachBreakpoint' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void didReachBreakpoint(const JSC::DebuggerCallFrame&, intptr_t sourceID, int lineno);
                 ^
/Volumes/Data/src/webkit.work/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/Debugger.h:52:22: note: hidden overloaded virtual function 'JSC::Debugger::didReachBreakpoint' declared here
        virtual void didReachBreakpoint(const DebuggerCallFrame&, intptr_t, int, int) { };

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.