[Webkit-unassigned] [Bug 90567] Make GC3D and E3D more maintainable for GLES platforms

Thu Jul 5 14:04:41 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=90567

Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150977|review?                     |review-
               Flag|                            |

--- Comment #17 from Rob Buis <rwlbuis at gmail.com>  2012-07-05 14:04:41 PST ---
(From update of attachment 150977)
View in context: https://bugs.webkit.org/attachment.cgi?id=150977&action=review

Looks good in general, can be cleaned up a bit more.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

Should be RIM copyright I think.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:185
> +

No need for empty line.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:267
> +

Ditto.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:277
> +

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.