[Webkit-unassigned] [Bug 83016] [GTK] Add webkit_cookie_manager_set_persistent_storage() to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83016





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-07-05 08:03:38 PST ---
(In reply to comment #8)
> (From update of attachment 147494 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147494&action=review
> 
> It looks mostly fine to me, but I'm missing the rationale for having our own sqlite implementation, especially since we're using the text one from soup. Could you add an explanation to the ChangeLog?

Sure. It's because the libsoup implementation is part of libsoup-gnome, for whatever reason. Dan told me that moving it to libsoup would be an abi break and he suggested to just copy the implementation in WebKit, since it's not a lot of code and it hardly ever changes.

> > Source/WebKit2/ChangeLog:35
> > +        new cookie jar for the given filename and sotrage type and add it
> 
> sotrage -> storage

Oops.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.