[Webkit-unassigned] [Bug 90542] [EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90542





--- Comment #6 from Kihong Kwon <kihong.kwon at samsung.com>  2012-07-05 02:13:09 PST ---
(In reply to comment #5)
> (From update of attachment 150768 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150768&action=review
> 
> > Source/WebKit/ChangeLog:8
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * PlatformEfl.cmake: Change file name from NotificationClientEfl.cpp to NotificationPresenterClientEfl.cpp
> 
> Would be nice with some reasoning for this change, like "to be in line with other ports"

OK.
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:24
> > +
> > +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> > +#include "Notification.h"
> 
> Shouldn't we instead remove support for legacy notifications?

Actually, legacy notification is used on the web for now. And I think we can remove legacy notification on the same time with other ports.
If there is not a problem to support legacy notification, I would like to support that also.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.