[Webkit-unassigned] [Bug 90542] [EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90542





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-07-05 01:43:42 PST ---
(From update of attachment 150768)
View in context: https://bugs.webkit.org/attachment.cgi?id=150768&action=review

> Source/WebKit/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * PlatformEfl.cmake: Change file name from NotificationClientEfl.cpp to NotificationPresenterClientEfl.cpp

Would be nice with some reasoning for this change, like "to be in line with other ports"

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:24
> +
> +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> +#include "Notification.h"

Shouldn't we instead remove support for legacy notifications?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.