[Webkit-unassigned] [Bug 90054] [EFL][WK2] Make ewk_view inheritable in the WebKit2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90054





--- Comment #17 from EunMi Lee <eunmi15.lee at samsung.com>  2012-07-04 23:35:52 PST ---
(In reply to comment #16)
> > Kenneth, thank you for your comments.
> > 
> > Yes, right. the mobile is getting important these days,
> > and I also considered how to support touch screens as well as supporting mouse.
> > but, in my conclusion, I can not support both touch screen and mouse at the same time now in the EFL port.
> > Because, Evas can not discriminate the touchscreen's input and mouse's input.
> > That means, Evas generates "Mouse Event" when we touch the touchscreen and it also generates "Mouse Event" for Mouse device's operation.
> > I want to do scrolling for "Mouse down, move, up" on the touchscreen, but I want to do dragging for that with the mouse device,
> > so, I can not support touch screen and mouse at the same time.
> 
> Qt has had the same issues but it is almost fixed now ;-) EFL developers should look at how we are fixing this. What you can do while this is not working is adding a method like "ewk_enable_mouse_events() / ewk_enable_touch_events()" to ignore one or the other. 

Thanks for your advice.I hope EFL becomes good like Qt and I have to study Qt port. :)
and, I will modify Bug 88631 to use API such as ewk_enable_touch_events() to distinguish touch and mouse event.

> 
> > Additionally, I think I can write the code to support touchscreen using "if else" statement in the all mouse event callback to separate the touchscreen and mouse in the ewk_view.cpp.
> > But, IMO, it is better to inherit and override the mouse event instead of using "if else" statement.
> 
> Then you will have a problem in the future when your view supports both. Think about the future :-)

Yes, right. If I add ewk_view_touchscreen, I have to merge codes of ewk_view_touchscreen to the ewk_view when view supports both mouse and touch.
I didn't consider about that. and I think it is better to use "if else" statement in this case. :)

> 
> > 
> > I really want to listen your thought about that. :)
> > 
> > BTW, This patch is for making ewk_view inheritable.
> > the ewk_view_touchscreen is just a one example of inheritance,
> > and I think it will be useful for applications to extend ewk_view functions if ewk_view is inheritable.
> 
> It can also easily become a can or worms (talking from experience). What is it that you need from the view that can only be solved by inheritance? why are free functions not good enough?

There is 8 Smart Class functions in the ewk_view such as mouse_down, key_down, focus_in and so on, and the ewk_view offers the default behavior of them.
I think application can want to do different operations for those Smart Class functions.
If we do not allow the inheritance, the application (or extending library) can not override Smart Class functions.
I don't want to restrict applications' possibility. so I want to make the ewk_view inheritable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.