[Webkit-unassigned] [Bug 90494] Implement device metrics for blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 09:53:39 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90494


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150808|review?                     |review+
               Flag|                            |




--- Comment #5 from Rob Buis <rwlbuis at gmail.com>  2012-07-04 09:53:39 PST ---
(From update of attachment 150808)
View in context: https://bugs.webkit.org/attachment.cgi?id=150808&action=review

LGTM.

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:93
> +void InspectorClientBlackBerry::overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool fitWindow)

fitWindow not used, so you can remove the name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list