[Webkit-unassigned] [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 08:41:41 PDT 2012


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #150804|review?                     |review+
               Flag|                            |

--- Comment #30 from Pavel Feldman <pfeldman at chromium.org>  2012-07-04 08:41:40 PST ---
(From update of attachment 150804)
View in context: https://bugs.webkit.org/attachment.cgi?id=150804&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:513
> +    , m_lowLevelEventsEnabledStackMark(0)

I would rename lowLevel to orphan for consistency. Otherwise looks good.

> Source/WebCore/inspector/InspectorTimelineAgent.h:202
> +    unsigned int m_lowLevelEventsEnabledStackMark;

just "unsigned"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list