[Webkit-unassigned] [Bug 90494] Implement device metrics for blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90494





--- Comment #2 from Konrad Piascik <kpiascik at rim.com>  2012-07-04 08:05:45 PST ---
(From update of attachment 150792)
View in context: https://bugs.webkit.org/attachment.cgi?id=150792&action=review

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:65
> +    OwnPtr<DeviceMetricsSupport> m_deviceMetrics;

New member variables should be declared last and initialized in the order they are declared in the header.  You're initializing in the correct order in your constructor but not declaring in the right order.

> Source/WebKit/blackberry/WebCoreSupport/InspectorDeviceMetrics.h:1
> +/*

This is a small class that's entirely declared in the header.  This is not good and should be moved into the InspectorClientBlackberry class we don't need a separate class for this functionality.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.