[Webkit-unassigned] [Bug 90530] REGRESSION(r121792): inspector/extensions/extensions-resources.html fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 03:14:01 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90530





--- Comment #3 from Andrey Kosyakov <caseq at chromium.org>  2012-07-04 03:14:01 PST ---
(From update of attachment 150750)
View in context: https://bugs.webkit.org/attachment.cgi?id=150750&action=review

> LayoutTests/http/tests/inspector/debugger-test.js:56
> +    InspectorTest.finishDebuggerTest(completeTest);
> +
> +    function completeTest()
> +    {
>          InspectorTest.completeTest();
>      }

Just InspectorTest.finishDebuggerTest(InspectorTest.completeTest.bind(this))?

> LayoutTests/inspector/extensions/extensions-resources-expected.txt:83
> -    1 : 11
> +    1 : 12

nit: you could as well have moved logMessage() to a separate <script> on the top of the file, so that we stop re-baselining the test upon adding new scripts.

> LayoutTests/inspector/extensions/extensions-resources.html:173
> +          return;

indent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list