[Webkit-unassigned] [Bug 89864] [EFL][WK2] Add ewk_view_ui_client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89864





--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-04 00:48:51 PST ---
(From update of attachment 150718)
View in context: https://bugs.webkit.org/attachment.cgi?id=150718&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:650
> +    Evas_Object* createdEwkView = 0;

I would use newEwkView instead of createdEwkView.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:30
> + * - "close,window", void: window is closed.

Place these signals by alphabetical order.

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:31
> +static void close(WKPageRef, const void* clientInfo)

I think *close* is not clear function name. Why don't you use closePage

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.