[Webkit-unassigned] [Bug 89864] [EFL][WK2] Add ewk_view_ui_client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89864





--- Comment #7 from Hyerim Bae <hyerim.bae at samsung.com>  2012-07-03 23:36:39 PST ---
(In reply to comment #6)
> (From update of attachment 150569 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150569&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:645
> > +    evas_object_smart_callback_call(ewkView, "close,window", 0);
> 
> I wonder how to close window by application ?
Application may delete the window in 'close,window' callback with obj argument.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:648
> > +WKPageRef ewk_view_new_page_create(Evas_Object* ewkView)
> 
> I think ewk_view_page_create is better. It seems to me *new* is unneeded.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:31
> > + * - "create,window", Evas_Object **: window is created.
> 
> Don't you need to use "a new window" ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.