[Webkit-unassigned] [Bug 90217] [chromium] Avoid calling getUniformLocation??() in the compositor startup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90217





--- Comment #15 from Adrienne Walker <enne at google.com>  2012-07-03 10:56:51 PST ---
(From update of attachment 150528)
View in context: https://bugs.webkit.org/attachment.cgi?id=150528&action=review

> Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:47
> +        if (uniformIndex >= maxLocations)
> +            return;

Can you just ASSERT here instead?  This should never happen.  Also, if this happens and you return after only getting some of the uniforms, the shader isn't going to work at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.