[Webkit-unassigned] [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90264


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150628|review?                     |review-
               Flag|                            |




--- Comment #26 from Pavel Feldman <pfeldman at chromium.org>  2012-07-03 10:06:16 PST ---
(From update of attachment 150628)
View in context: https://bugs.webkit.org/attachment.cgi?id=150628&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:1140
> +InspectorTimelineAgent* InspectorInstrumentation::timelineAgentInstance()

Nit: here and below: there is no need for "Instance" suffix.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:1153
> +    return instance;

You should return reference here.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:513
> +    , m_lowlevelEventsEnabledStackMark(-1)

Can we get away with 0 as the default value?

> Source/WebCore/inspector/InspectorTimelineAgent.h:165
> +    void pushCurrentRecord(PassRefPtr<InspectorObject>, const String& type, bool captureCallStack, Frame*, bool hasLowlevelDetails = false);

hasLowLevelDetails

> Source/WebCore/inspector/InspectorTimelineAgent.h:167
> +        

Remove new chars

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.