[Webkit-unassigned] [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 08:54:54 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90264





--- Comment #23 from Andrey Kosyakov <caseq at chromium.org>  2012-07-03 08:54:53 PST ---
(From update of attachment 150619)
View in context: https://bugs.webkit.org/attachment.cgi?id=150619&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:468
> +void InspectorTimelineAgent::didCompleteCurrentRecord(const String& type, bool hasLowlevelDetails)

I don't think we need to pass hasLowLevelDetails explicitly to didCompleteCurrentRecord() -- instead, use something like m_levelLowLevelEventsEnabledStackMark = m_recordStack.size(); then disable them once we popped back to this depth.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list