[Webkit-unassigned] [Bug 90166] NEON intrinsics should be used with gaussian blur filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90166


Gabor Rapcsanyi <rgabor at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150397|0                           |1
        is obsolete|                            |
 Attachment #150397|review?                     |
               Flag|                            |
 Attachment #150605|                            |review?
               Flag|                            |




--- Comment #8 from Gabor Rapcsanyi <rgabor at webkit.org>  2012-07-03 07:24:19 PST ---
Created an attachment (id=150605)
 --> (https://bugs.webkit.org/attachment.cgi?id=150605&action=review)
patch3

(In reply to comment #5)
> (From update of attachment 150397 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150397&action=review
> 
> > Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:127
> > +            if (!isAlphaImage())
> > +                boxBlurNEON(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height(), isAlphaImage());
> > +            else
> > +                boxBlur(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height(), isAlphaImage());
> 
> Since isAlphaImage() is known at this point, we should pass true to boxBlur and remove the bool argument from boxBlurNEON. If we ever make an alpha based version, it will have a different name, since the code cannot be shared.

Yes, I removed it.

> 
> > Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h:32
> > +using namespace std;
> 
> We should not add using to a header file... We should use std:: if it is really needed.

Removed as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.