[Webkit-unassigned] [Bug 90420] JSC: Add ability to symbolically set and dump JSC VM options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90420


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150523|0                           |1
        is obsolete|                            |




--- Comment #16 from Mark Lam <mark.lam at apple.com>  2012-07-02 23:24:33 PST ---
Created an attachment (id=150544)
 --> (https://bugs.webkit.org/attachment.cgi?id=150544&action=review)
rev 3: Used typedef trick to eliminate the '_' altogether + addressed Filip's comments.

The windows build seemed to refuse to build because the style checker had complained about the '_' in the var names.  I've applied Gavin's typedef trick to alias int32_t as int32 inside the Option class so as to workaround this issue.

Regarding Filip's comments:

>> Source/JavaScriptCore/jsc.cpp:618
>>+    fprintf(stderr, "  --options                  Dumps all JSC VM options and exits\n");
>
>Typo: "and exit"

The comment says "Dumps ... and exits".  This is consistent in being 3rd person singular, which many of the pre-existing comments were also.  A quick survey of 3rd person singular forms of "exit" on the net seems to agree that "exits" is the proper form.  So, I'm leaving it as is.

>>Source/JavaScriptCore/jsc.cpp:619
>>+    fprintf(stderr, "  --dumpOptions              Dumps all JSC VM options before continuing\n");
>
>Is this option needed?

Addressed in previous comment.  It's useful when we want to invoke a test with some options, and wanting the options documented in the output of the test in one swoop.  Plus, it's just a  few lines of code.  I would prefer to keep it.

The other issues are all now fixed.  Will set flags to r? cq? when the build bot are happy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.