[Webkit-unassigned] [Bug 82155] DFG OSR exit value recoveries should be computed lazily

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 18:27:01 PDT 2012


--- Comment #20 from Filip Pizlo <fpizlo at apple.com>  2012-07-02 18:27:01 PST ---
(In reply to comment #18)
> (From update of attachment 134256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134256&action=review
> It seems that it might be cleaner at some point to refactor GenerationInfo, so that rather than being a class representing a single value & having a Vector of them, to instead have GenerationInfo be a container holding info for N variables, and make all methods be passed the virtual register to be operated on.  Then the generation info could hold a reference to m_stream as a member, which would better encapsulate the implementation.
> Apologies again on the delay on reviewing this, r+, please re-test performance before landing.

The performance still looks good!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list