[Webkit-unassigned] [Bug 90317] [V8] Use WebCore::root for V8 bindings too

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90317





--- Comment #2 from Erik Arvidsson <arv at chromium.org>  2012-07-02 09:38:17 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > it seems like we should use WebCore::root too. I think we can get rid of all non Node cases by delegating to the WebCore::root value.
> 
> I would guess root() is not a WebCore method but a method implemented in JSDOMBinding.h. We might want to move it to Node.h so that both JSC and V8 can use it.

Yeah, right now these are only used by the JSC bindings. I was thinking to put them in Source/WebCore/bindings/.

Node.h is not the right place for these. Some of them are unrelated to Nodes (WebCore::root(StyleSheet*) for example).

> Just in case, would you elaborate on the overall goal of the work?

There are two goals here.

1. Correctness. Reachable wrappers should not be collected.
2. Security. If GC is observable it can be used as a covert channel.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.