[Webkit-unassigned] [Bug 90376] [Qt][WK2] fast/viewport/viewport-91.html still fails after r121555 and r121661

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90376





--- Comment #3 from Balazs Kelemen <kbalazs at webkit.org>  2012-07-02 07:01:45 PST ---
(In reply to comment #2)
> I think the WebKit2 part of the original patch is not enough:
> 
> diff --git a/Source/WebKit2/WebProcess/WebPage/WebPage.cpp b/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
> -    ViewportAttributes attr = computeViewportAttributes(m_page->viewportArguments(), minimumLayoutFallbackWidth, deviceWidth, deviceHeight, static_cast<int>(160 * m_page->deviceScaleFactor()), m_viewportSize);
> +    ViewportAttributes attr = computeViewportAttributes(m_page->viewportArguments(), minimumLayoutFallbackWidth, deviceWidth, deviceHeight, m_page->deviceScaleFactor(), m_viewportSize);
> 
> Only the Mac port set up the deviceScaleFactor for the page, other ports leave it to the embedder. I think we should either set this up for every port or just allow ports to use the old (deprecated?) behavior.

Ehh, I'm wrong, this should not change anything. But than how was it good, and how went it wrong???

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.